-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build_test_package.py osc syntax #3473
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Note, this change was added in openSUSE/osc@677c741
CI errors are PEP8 linter issues. Should be easy to fix though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems, there is an import for "version" missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mistakenly pushed from the wrong branch. Let me push the correct changes.
As of osc version 0.164.2 the --all option must be supplied on deleterequest operations. This changes allow build_test_package.py to work on systems with newer versions of open build service commander.
e8ba5d2
to
d58ae4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Looks great!
Still a PEP8 error in CI. This time a different error 😉 |
Yeah, I'm still fighting with this. I'm getting conflicting directives about what should go where locally. Stay tuned..... |
needs a rebase |
As of osc version 0.164.2 the --all option must be supplied on
deleterequest operations. This changes allow build_test_package.py
to work on systems with newer versions of open build service commander.